Help with Complex VBA program

macropod · #2 04-24-2017, 04:53 AM

Your attached template contains over 1000 lines of code. That's a lot to ask anyone to analyse, looking for problems. Some of it seems unnecessarily convoluted, too. For example, you could probably replace the calls to getNameOnly, which invokes:

Code:

Function getCurName() As String
    getCurName = LCase(ActiveDocument.name)
End Function

Function getNameOnly() As String
    Dim testString As String
    Dim lastIndex As Integer
    lastIndex = InStrRev(getCurName(), ".") - 1
    testString = Mid(getCurName(), lastIndex, Len(getCurName()) - lastIndex)
    getNameOnly = Mid(getCurName(), 1, lastIndex)
End Function

with:

Code:

LCase(Split(ActiveDocument.Name, ".doc")(0))

You could most certainly replace statements like:

Code:

ActiveDocument.path + "\" + ActiveDocument.name

with:

Code:

ActiveDocument.FullName

Usually, if the execution behaviour changes, it's because someone has changed the code or done something to the data structures (e.g. file/folder names) that invalidates the assumptions upon which the code works. I suggest you review whatever changes might have been made in those respects.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Complex Directory	Optional_karl	Mail Merge	1	09-29-2016 01:54 PM
a complex IF formula perhaps?	robfreeman	Excel	3	05-17-2016 04:58 AM
I need help for a complex projet at my job	Elok	Word	4	01-10-2013 08:28 AM
Giant table with numbers, complex text, images: Which program?	8ruk3r	Office	2	11-23-2012 05:31 PM
Complex array formula	andrei	Excel	9	02-03-2012 03:40 AM