Third Column? I thought we said just columns C and D that's exactly why your third column is not updating because I wrote it for Columns C and D. Below will work through a third column as well.
Code:
Option Explicit
Dim cwb As Workbook, ws As Worksheet
Sub RemoveAllCarriageReturns()
'Goes through all files of a specified folder and removes all
'carriage returns from Columns C and D and replaces them with a comma
'Saves the workbook with the same name in the folder and moves to the next file.
Dim FolderString As String, StrFile As String, Confirm As String, wb As Workbook
Confirm = MsgBox("This code will replace all carriage returns and line breaks with a comma." & vbLf & _
"This will be done to every single workbook within the folder that you specify." & vbLf & _
"It is strongly recommended that you create the necessary backups before running this code." & vbLf & _
"Do you wish to continue?", vbYesNo)
If Confirm = vbNo Then End
Set wb = ThisWorkbook
FolderString = InputBox("Folder Location:")
If FolderString = "" Then End
'Set the file folder
StrFile = Dir(FolderString & "/")
Do While Len(StrFile) <> 0
If InStr(1, StrFile, ".xl") <> 0 Then
Set cwb = Workbooks.Open(FolderString & "/" & StrFile)
Debug.Print cwb.Name
Set ws = cwb.Worksheets(1)
LineBreakReplace
cwb.Save
cwb.Close
End If
Set cwb = Nothing
Set ws = Nothing
StrFile = Dir()
Loop
MsgBox ("Complete")
End Sub
Function LineBreakReplace()
Dim CTotalRows As Long, DTotalRows As Long, TotalRows As Long, x As Byte
Dim CheckRow As Long, CheckString As String, BadData As Variant
Dim DblCommaGone As Boolean, ETotalRows As Long
'Find the Last Row
CTotalRows = ws.Range("C50000").End(xlUp).Row
DTotalRows = ws.Range("D50000").End(xlUp).Row
ETotalRows = ws.Range("E50000").End(xlUp).Row
TotalRows = WorksheetFunction.Max(CTotalRows, DTotalRows, ETotalRows)
On Error GoTo 0 'Reset error handling and enter line breaks in the array
BadData = Array(vbCr, vbLf, vbCrLf, Chr(10), Chr(13))
'Clean Column C
For CheckRow = 1 To TotalRows
CheckString = ws.Range("C" & CheckRow).Value
For x = 0 To 4
If InStr(1, CheckString, BadData(x)) Then
ws.Range("C" & CheckRow).Value = Replace(CheckString, BadData(x), ",")
End If
Next x
'Now clear the commas
Do Until DblCommaGone = True
CheckString = ws.Range("C" & CheckRow).Value
If InStr(1, CheckString, ",,") = 0 Then
DblCommaGone = True
Else
ws.Range("C" & CheckRow).Value = WorksheetFunction.Substitute(CheckString, ",,", ",")
End If
Loop
DblCommaGone = False
Next CheckRow
'Clean Column D
For CheckRow = 1 To TotalRows
CheckString = ws.Range("D" & CheckRow).Value
For x = 0 To 4
If InStr(1, CheckString, BadData(x)) Then
ws.Range("D" & CheckRow).Value = _
WorksheetFunction.Substitute(CheckString, BadData(x), ",")
End If
Next x
'Now clear the commas
Do Until DblCommaGone = True
CheckString = ws.Range("D" & CheckRow).Value
If InStr(1, CheckString, ",,") = 0 Then
DblCommaGone = True
Else
ws.Range("D" & CheckRow).Value = WorksheetFunction.Substitute(CheckString, ",,", ",")
End If
Loop
DblCommaGone = False
Next CheckRow
'Clean Column E
For CheckRow = 1 To TotalRows
CheckString = ws.Range("E" & CheckRow).Value
For x = 0 To 4
If InStr(1, CheckString, BadData(x)) Then
ws.Range("E" & CheckRow).Value = _
WorksheetFunction.Substitute(CheckString, BadData(x), ",")
End If
Next x
'Now clear the commas
Do Until DblCommaGone = True
CheckString = ws.Range("E" & CheckRow).Value
If InStr(1, CheckString, ",,") = 0 Then
DblCommaGone = True
Else
ws.Range("E" & CheckRow).Value = WorksheetFunction.Substitute(CheckString, ",,", ",")
End If
Loop
DblCommaGone = False
Next CheckRow
End Function