Help with bookmarks in word.

gorkac · #1 08-31-2021, 09:56 PM

Hi Mr. Mayor. I need a last favor.

In the same document, there are parts to fill in with the same bookmarks, but Word does not allow repeating the name of the bookmarks "termino", and so on. What lines can I add so that I fill in a new bookmark named "termino2", for example, what is filled in the marker "termino"?

Quote:

Originally Posted by gmayor

You probably need something like the following, but if there are lots of these values as seems to be the case you would be better putting the codes and their values in an Excel worksheet and reading them from the worksheet.

Code:

Private Sub CommandButton2_Click()
Dim sVia As String
Dim lPK As String
    sVia = ComboVia.Text
    lPK = textPK.Value
    Select Case sVia
        Case Is = "A-68"
            If lPK > 81 And lPK < 85 Then
                Rellenar "termino", "Castejon"
                Rellenar "partido", "Tudela"
            End If
            If lPK > 84 And lPK < 99 Then
                Rellenar "termino", "Corella"
                Rellenar "partido", "Estella"
            End If
            If lPK > 98 And lPK < 113 Then
                Rellenar "termino", "Fontellas"
                Rellenar "partido", "Tafalla"
            End If
        Case Is = "NA-3010"
            If lPK > 20 And lPK < 25 Then
                Rellenar "termino", "Cortes"
                Rellenar "partido", "Tudela"
            End If
            If lPK > 24 And lPK < 35 Then
                Rellenar "termino", "Ribaforada"
                Rellenar "partido", "Tafalla"
            End If
            If lPK > 34 And lPK < 44 Then
                Rellenar "termino", "Novillas"
                Rellenar "partido", "Estella"
            End If
    End Select
lbl_Exit:
    Exit Sub
End Sub

gorkac · #2 08-17-2021, 06:30 AM

Oh, wow, I wouldn't know how to thank you for so much help. I'll get down to business with the code. If I have any further questions, I will let you know. Many thanks

Guessed · #3 08-17-2021, 07:10 PM

You can simplify your code to make it faster to implement and maintain.
For instance, I would get rid of the Carreteras module and replace the UserForm_Activate macro in the userform's module with this to streamline that part.

Code:

Private Sub UserForm_Initialize()
  Dim sVia As String, arr() As String
  sVia = "AP-15:AP-68:A-1:A-10:A-12:A-15:A-21:A-68:PA-30:PA-31:PA-32:PA-33:PA-34:N-111:" & _
          "N-113:N-121:N-121-A:N-121-B:N-121-C:N-135:N-232:N-240:N-240-A"
  arr = Split(sVia, ":")
  Me.cbovia.List = arr
End Sub

Do you have a spreadsheet or table to read the possible exit values? That would make loading the dependent exits a lot more streamlined.

If you are going to enter all that data directly in VBA code, try to do it with as little duplication or complexity as possible. Graham's code could also be trimmed a bit along these lines

Code:

Private Sub CommandButton2_Click()
  Dim sVia As String, lPK As String, sTermPart As String, arr() As String
  sVia = ComboVia.Text
  lPK = textPK.Value
  Select Case sVia
    Case Is = "A-68"
      If lPK < 85 Then
        sTermPart = "Castejon|Tudela"
      ElseIf lPK < 99 Then
        sTermPart = "Corella|Estella"
      Else
        sTermPart = "Fontellas|Tafalla"
      End If
    Case Is = "NA-3010"
      If lPK < 25 Then
        sTermPart = "Cortes|Tudela"
      ElseIf lPK < 35 Then
        sTermPart = "Ribaforada|Tafalla"
      Else
        sTermPart = "Novillas|Estella"
      End If
  End Select
  If UBound(arr) > 0 Then
    arr = Split(sTermPart, "|")
    Rellenar "termino", arr(0)
    Rellenar "partido", arr(1)
  End If
End Sub

Guessed · #4 08-18-2021, 01:55 AM

I've looked over all this thread and think the solution is growing in complexity with considerable repetitive code to still be written.

I suggest taking a reset and look at this from a different perspective. Attached is an example which aligns with what I think the OP wanted. It avoids the userform in favour of mapped Content Controls and either CC properties or macros to populate the CC values.

gorkac · #5 08-18-2021, 02:20 AM

Thank you very much, I will try it. I can't put the code like this "If lPK <85 Then ..." because they are roads and their miles (kilometros). Depending on which miles we talk between, one "termino" or another will be written. PK are "kilometros" (unit of measurement on European roads, you use the mile).
There are roads ("carreteras") that do not start at zero, but can start at mile (kilometro) 12.400 and end at mile (kilometro) 36.700, for example.

Guessed · #6 08-18-2021, 03:48 PM

Are you planning on coding all the information or read it from a table?

It is not a stretch to deal with decimal places or starting distances but you need to decide on how all the data is going to be sourced.

gorkac · #7 08-18-2021, 04:00 PM

I code all the information, I have already started and it works fine.
How do I implement error checks? If I have a value that does not exist, how do I not fill in what I want?
Example:
Case Is = "NA-3010"
If lPK > 20 And lPK < 25 Then
Rellenar "termino", "Cortes"
Rellenar "partido", "Tudela"
End If
If lPK > 24 And lPK < 35 Then
Rellenar "termino", "Ribaforada"
Rellenar "partido", "Tafalla"
End If
If lPK > 34 And lPK < 44 Then
Rellenar "termino", "Novillas"
Rellenar "partido", "Estella"
End If
End Select
As I control in the case that the user enters for example the lPK 67 (does not exist)

Guessed · #8 08-18-2021, 04:14 PM

You need to join the If statements to isolate the invalid ranges. Look back over the provided code for instances of ElseIf to see the structure you need to show invalid distances. The basic premise is as follows.

If test then
' do something
ElseIf test2 then
' do something else
Else
' what happens when the distance isn't valid
End If

gorkac · #9 08-19-2021, 12:21 PM

What IDE or code editor do you use for vba word?

Guessed · #10 08-19-2021, 03:18 PM

For me it is Word's own VBA Editor - opened from Word by pressing Alt-F11

gorkac · #11 08-20-2021, 10:02 AM

Yeah yeah, I work with that one. I was asking if you knew something better

gorkac · #12 08-21-2021, 12:04 PM

Hi guys, one last help. As the procedure is very long, I get an error.
I'll give you the file, let's see how I can divide the "carreteras" routine into several parts. Notice, I still have to insert half of the information.

Thanks in advance.

gorkac · #13 08-21-2021, 12:07 PM

I forgot to upload the document

gorkac · #14 08-21-2021, 12:25 PM

I see that the problem is that in the same procedure, I have written more than 6000 lines of code.
How can i divide it?

gorkac · #15 08-21-2021, 12:48 PM

Sorry, too long procedure is in the form

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Saving a word doc as a pdf with bookmarks	MimiCush	Word	10	03-26-2018 01:51 PM
Deleting only all bookmarks contents not the bookmarks	adilprodigy	Word VBA	1	10-11-2017 01:31 PM
Form updating Bookmarks - writes to the bookmarks multiple times	PeterPlys	Word VBA	13	01-14-2015 06:41 AM
selecting ms word bookmarks using vba	dnc	Word VBA	4	05-10-2013 04:58 PM
word 2007 bookmarks	Dawn	Word	0	07-14-2009 01:00 PM