Macro to append text to end of paragraphs/lines where target text is found.

[moorea21]

Hi,


I am trying to use this code:-


Sub Rpl()
Dim singleLine As Paragraph
Dim lineText As String
Dim MyPos

For Each singleLine In ActiveDocument.Paragraphs
lineText = singleLine.Range.Text

MyPos = InStr(lineText, "Test Text")
'If MyPos = 1 Then Replace(lineText , lineText & "LxW ")
If MyPos = 1 Then lineText = lineText & "LxW "
Next singleLine
End Sub


Although the value of 'lineText' gets updated, it doesn't replace it in the document, so I tried a VB6 'replace' function, which is invalid. How would I get the new value of lineText to replace the old value in the document?


Thanks

[d4okeefe]

Try this. I prefer to use a for loop (rather than a for each loop) here.

Sub Rpl()
    Dim lineText As String
    Dim MyPos
    
    Dim x As Integer
    For x = 1 To ActiveDocument.Paragraphs.Count
        lineText = ActiveDocument.Paragraphs(x).Range.Text
        MyPos = InStr(lineText, "Test Text")
        If MyPos = 1 Then
            ActiveDocument.Paragraphs(x).Range.Text = lineText & "LxW "
        End If
    Next x
End Sub

Also, notice that in your original you only change the string -- lineText. The actual paragraph -- singleLine -- is never changed.

[moorea21]

Originally Posted by d4okeefe

Also, notice that in your original you only change the string -- lineText. The actual paragraph -- singleLine -- is never changed.

Of course! Obvious now it's pointed out, thank you for that.


Only trouble is, I'm getting an overrun mnaeesage; error 6. There are over 430,000 paragraphs in the document, is that beyond what x can equal?

[d4okeefe]

Try ...

Dim x As Long

... in place of ...

Dim x As Integer

[moorea21]

Good idea. Seems I'm a bit rusty at this game.

[macropod]

You don't even need a macro for this - just a wildcard Find/Replace, where, for example:
Find = (Test Text*)^13
Replace = \1 LxW^p
And if you're wedded to using a macro, the above recorded as one would be way faster than looping through every paragraph.

[moorea21]

Thanks Paul, I tried that, it couldn't find the target text. Below is an example of the format of text the document contains:


Test Text 21.04.18 22:03:00
Hello!




Test Text2 21.04.18 22:04:00
Hello!


etc.


The first line should end up reading



Test Text 21.04.18 22:03:00 LxW

[macropod]

Works for me! Did you check the 'use wildcards' Find option?

[moorea21]

Erm, no... Duh!
Yes it works great, a lot faster than a macro, which I only used as I couldn't work out how to do it your way! Thanks.