Microsoft Office Forums

Go Back   Microsoft Office Forums > >

Reply
 
Thread Tools Display Modes
  #1  
Old 03-27-2012, 06:22 PM
mark-gabb mark-gabb is offline can someone look at a book ive worked on and suggest improvements Windows XP can someone look at a book ive worked on and suggest improvements Office 2007
Novice
can someone look at a book ive worked on and suggest improvements
 
Join Date: Nov 2011
Posts: 17
mark-gabb is on a distinguished road
Red face can someone look at a book ive worked on and suggest improvements


hi everyone well after months of trying to keep this thing working im still not quiet there....

would it be possible for someone to have a look and proof my work, you know kind of help me make it more robust?

keep having issues with people moving rows and insterting rows that throw everything i work on out the window......

any help you guys can give me would be greatly appreciated


as a noter when someone copy or cut and pastes data on the PSAG i end up with a #href issue on the handover sheet....

can get very annoying

thanks to anyone who can help me
Attached Files
File Type: xlsm PSAG 3.5 - Copy.xlsm (131.5 KB, 14 views)
Reply With Quote
  #2  
Old 03-28-2012, 11:13 AM
excelledsoftware excelledsoftware is offline can someone look at a book ive worked on and suggest improvements Windows 7 64bit can someone look at a book ive worked on and suggest improvements Office 2003
IT Specialist
 
Join Date: Jan 2012
Location: Utah
Posts: 453
excelledsoftware will become famous soon enough
Default

You have hundreds of macros in this workbook are they all necessary? I looked at some of your basic formatting where you have some opportunity. The way a workbook is formatted will show professionalism and makes it less tempting for some Yahoo to go around unprotecting worksheets and inserting rows etc. What I mean is your red yellow and green boxes are not all aligned this can easily be fixed by holding ctrl and shift when dragging one of the colors. It will keep them perfectly aligned and duplicate the shapes. Also you have center formatting applied on some of your columns but the words are not all centered you should look at this.

as far as your Ref# that you are getting this will happen anytime you paste or move a formula that disturbes another formula in a workbook. So maybe you have another formula in your workbook that is being corrupted when you paste the data.

Lastly alot of your ideas on this workbook are great it looks like it has a great layout give us some specifics on what the workbook is suppose to do and maybe we can give you a hand to simplify all of the vba.

Thanks and good job.
Reply With Quote
  #3  
Old 03-28-2012, 07:56 PM
mark-gabb mark-gabb is offline can someone look at a book ive worked on and suggest improvements Windows XP can someone look at a book ive worked on and suggest improvements Office 2007
Novice
can someone look at a book ive worked on and suggest improvements
 
Join Date: Nov 2011
Posts: 17
mark-gabb is on a distinguished road
Default

i dont think they are all neccicary but i dont know VBA well enough to try and reduce them....

basically this board is a work to try and improve patient flow in the hospital i work for

its a running sheet that shows the patients and referals on PSAG sheet...
and copies itself over to the handover with important information to be printed off once per shift for the staff to carry around with them

most of the macros are used connected to the arrows down the left hand side.... they are for discharge, when you click on it it asks if your sure then erases all patient data off both PSAG and Handover. i couldnt think i of a way to make it work where you just select a patient and click on a single discharge and have it translate correctly on the next sheet...

another macro or set of macros is tied to the colour boxes on the top of the screen

if you click under a area or profession and then click a colour it just changes the colour of the cell...

this is used as a trafic light system for referals to make tracking easier...

the other two macros are for repairs when they move patients around corrupting the formulas so you click it to make the formatting and formulas replace themselves and start working again

the other one is to fix the borders and cell spacing incase people play with them


my biggest issue people playing with all the stuff and erasing formulas and adding columbs and rows when there is no need for it....

original idea was to use shared workbook and have our services for referals be able to view and update referals from there desktop but i could never get it to work properly with the macros in place...

any other information about the board please feel free to ask
Reply With Quote
  #4  
Old 04-11-2012, 08:35 PM
mark-gabb mark-gabb is offline can someone look at a book ive worked on and suggest improvements Windows XP can someone look at a book ive worked on and suggest improvements Office 2007
Novice
can someone look at a book ive worked on and suggest improvements
 
Join Date: Nov 2011
Posts: 17
mark-gabb is on a distinguished road
Default

guess im out of luck on this one?
Reply With Quote
  #5  
Old 04-11-2012, 08:41 PM
mark-gabb mark-gabb is offline can someone look at a book ive worked on and suggest improvements Windows XP can someone look at a book ive worked on and suggest improvements Office 2007
Novice
can someone look at a book ive worked on and suggest improvements
 
Join Date: Nov 2011
Posts: 17
mark-gabb is on a distinguished road
Default

as further note i have recently has issues with people moving colums because they can unprotect the sheet, but i havnt been able to find away around this as excel wouldnt unprotect and protect a passworded protected file....

maybe shared workbook?
but then i have no idea how to use the repair function on protected cells, without stopping the sharing actions

hopefully on day i will have this avialable on everyones desktop so that they can fill out there sections from there own desktop
Reply With Quote
Reply

Tags
excel 2007, macros, vb

Thread Tools
Display Modes


Similar Threads
Thread Thread Starter Forum Replies Last Post
Outlook cannot open error messages no fixes have worked so far safogel Outlook 4 03-02-2017 11:19 AM
can someone look at a book ive worked on and suggest improvements Help with 'hours worked' calculation... Snvlsfoal Excel 1 08-11-2011 05:54 AM
Finding where I last worked on a document. Balliol Word 1 11-24-2010 04:50 AM
can someone look at a book ive worked on and suggest improvements can't see address book keithsibille Outlook 1 12-28-2009 09:07 AM
Submission of book in PDF tommyvin Word 0 10-07-2008 11:27 AM

Other Forums: Access Forums - Senior Forums

All times are GMT -7. The time now is 12:52 AM.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2020, vBulletin Solutions Inc.
Search Engine Optimisation provided by DragonByte SEO (Lite) - vBulletin Mods & Addons Copyright © 2020 DragonByte Technologies Ltd.
MSOfficeForums.com is not affiliated with Microsoft