You haven't given any hints about which bit is not working and I don't have time to try to guess.

Either post a sample document or tell us which line is causing an error.

Certainly explicitly naming the userform in a couple of lines but not in others is not great for consistency but without knowing where to look doesn't help us help you.

__________________
Andrew Lockton
Chrysalis Design, Melbourne Australia